Code review for WaziGate dashboard V3#57
Open
cdupont wants to merge 1020 commits intoreview/review_CDUfrom
Open
Code review for WaziGate dashboard V3#57cdupont wants to merge 1020 commits intoreview/review_CDUfrom
cdupont wants to merge 1020 commits intoreview/review_CDUfrom
Conversation
UI updates
UI updates
final changes
Avoid expired token refresh before login.
…ing for unregistered cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is my review summary:
Separate Actuators and Sensors in different files (see my comments).
The Context should be separated between Devices, Users, Apps...
Create subfolders for the various sections of the website: "devices", "apps", "settings", and place all related components there
Styling: I think we need to put the styles in a centralized place (e.g. styles.tsx). We need common styles for titles (t1, t2, t3), boxes, buttons...
Add comments in the code, especially on top of complex functions, to explain what the function does and why. Comments everywhere are not needed, just a few comments where they are necessary.
General cleaning (remove usused codes and files, code styling, improve some namings...).
PS. This pull request is just for code review, we will not merge it. You can work on the main branch. Thank you